Closed lkpttn closed 8 years ago
Huh, I wonder where that ESLint error came from... definitely not related to your PR.
Up for discussion, I added padding on the other side to balance it out.
I think that could cause layout issues elsewhere since these will usually get padding from being inside a gallery (or other container of sorts).
After looking at things more carefully (it's been forever since I've :art:ed), I'm remembering that our media pattern doesn't "collapse" into a single column on mobile unless the image is so big that it "forces" it to by breaking the layout. I ended up adding new .-drop-left
and .-drop-right
modifiers in the blog for a scenario like this... could make sense to move those into Forge and use here.
Yeah I think that makes sense, brining in the drop patterns. We get a lot of ugly in-betweens if it tries to do two columns on sizes smaller than medium.
… side
Up for discussion, I added padding on the other side to balance it out. Removing the padding overall on mobile did some funky things I didn’t quite understand but the text got pushed around.