Closed DFurnes closed 8 years ago
awesome-sauce :spaghetti: on pulling out the configs into separate repos :dancers:
Updates to Modernizr v3. This removes the (often buggy) grunt-modernizr plugin in favor of just using the official CLI directly.
yaaaais!
Bad news: Modernizr no longer supports including custom tests, so we just have to "fake" a test in our forge.js bundle for the "label click" test.
Really? that seems like a step backwards for them :(
Yeah, it's a bit of a bummer. There's an open issue discussing it, but it seems like the fix is blocked due to potential security concerns because the web interface uses the same "builder" codebase. :confused:
Cool. So it seems like they want to add it, but the security concern is the hold up. Once they figure something out we can always do an upgrade if we need to add custom stuff in :)
hooooboy! lots of stuff, but all really :sunglasses:
:+1:
:bow:
Changes
CSS, what's that?! :information_desk_person: This PR includes some "housekeeping" that I wanted to bunch up with our Forge 6.7 changes happening this sprint.
:100: Updates ESLint rules & uses a shared config package
@dosomething/eslint-config
that I'd made back when we did our documentation sprint. Makes some tiny updates in cases where we were following slightly different rules before.:construction_worker: Similarly, extracts Webpack config into a shared
@dosomething/webpack-config
package that we can share between all of our projects (inspired by Fender!):art: And with that new shared Webpack config, we can also use Webpack to build our stylesheets! This lets Webpack handle asset bundling/hashing & opens us up to some other cool possibilities in the future.
:speech_balloon: Updates Babel, our JavaScript compiler, to 6.x.
:chart_with_upwards_trend: Updates to Modernizr v3. This removes the (often buggy)
grunt-modernizr
plugin in favor of just using the official CLI directly. Good news: we can now use the bundledchecked
test rather than our copied version. Bad news: Modernizr no longer supports including custom tests, so we just have to "fake" a test in ourforge.js
bundle for the "label click" test.:wrench: Splits out Susy & helpers into a
toolkit.scss
file. Also bundles up our "base" styles into abase.scss
that could be included when making projects that don't use the full DS branding, like Voting App.:door: Adds a new
index.js
entry point in the root of the project. This acts as a table-of-contents for loading in styles and scripts, and sets the stage for potentially having multiple entry points in future releases (e.g. aforge/admin
orforge/lite
, etc.):whale: Updates Wercker config to use their new Docker stack. We needed a more up-to-date version of NPM than was included on the classic Node stack, so why not!
For review: @DoSomething/front-end