DoSomething / forge

🎨 The DoSomething.org pattern library.
http://forge.dosomething.org
MIT License
48 stars 14 forks source link

Update banner styling for Forge 6.7 #536

Closed DFurnes closed 8 years ago

DFurnes commented 8 years ago

Changes

Some fresh new CSS! This PR adds the new banner style that's going to be introduced in Forge 6.7 to the pattern library, replacing the old banner style. :art:

Screenshots

With shorter heading text:

screen shot 2016-03-21 at 3 51 13 pm

With longer text that expands past the yellow bar:

screen shot 2016-03-21 at 3 38 27 pm

With extra-long text that wraps to another line:

screen shot 2016-03-21 at 3 39 07 pm

And here it is on the profile page: screen shot 2016-03-21 at 4 34 33 pm

And on the action page: screen shot 2016-03-21 at 4 34 41 pm

And finally, here's how things look on mobile devices:

screen shot 2016-03-21 at 4 42 51 pm

For review: @DoSomething/front-end @lkpttn

DFurnes commented 8 years ago

Ignore the :red_circle: from Wercker, that got fixed up in #535.

weerd commented 8 years ago

Does it make sense to still call this modifier .-banner? Just throwing that out there... I like the new look, but doesn't really seem like a banner now. Maybe .-emphasized

weerd commented 8 years ago

Not a huge deal though.. just thought I'd mention it. If otherwise fine, I'm cool with it ;) Would mean updating the templates, which is probs not much fun...

DFurnes commented 8 years ago

Mmm, I'd be open to adding .-emphasized as an alternative class name option (and perhaps deprecating .-banner), but since this is replacing the existing banner pattern I don't want to do anything that'd break existing client applications.

lkpttn commented 8 years ago

+1 C'Thun +1 Design

We might have to revisit the bottom space after we update the typographic scale..

weerd commented 8 years ago

@DFurnes yeah, good points. Maybe add a note regarding that somewheres?

:+1:

DFurnes commented 8 years ago

@weerd Good idea! Added #537 to track that.

Also just added a .-banner.-inverse for the "prove it" section in 0e4fb55.

screen shot 2016-03-21 at 4 59 47 pm

weerd commented 8 years ago

:+1: :dancers: