DoSomething / forge

🎨 The DoSomething.org pattern library.
http://forge.dosomething.org
MIT License
48 stars 14 forks source link

Update font sizes and line spacing. #538

Closed DFurnes closed 8 years ago

DFurnes commented 8 years ago

Changes

This PR updates font sizes & line spacing based on new values specified by @lkpttn. It also adds more generous line spacing to wider container elements, and increased spacing between paragraphs.

Screenshots

Here's the pattern library with the old values: old typography

And with the new values: new typography

...no really, they're different! :mag: :eyes: animated-2016-03-23_15h-30m-58s


For review: @DoSomething/front-end

lkpttn commented 8 years ago

I think this is good to merge in for testing, we may tweak a bit more depending on how it looks on thor/staging.

DFurnes commented 8 years ago

@weerd @sbsmith86 Ready for another review! Added a type-scale() function to tidy up where those numbers come from & one unrelated change to the .heading.-banner pattern.

weerd commented 8 years ago

Nice! Really like the new scale function :dancer: :+1:

sbsmith86 commented 8 years ago

Love the type_scale() stuff! looks good to me ;)