Don't bundle jQuery with Forge.

DoSomething / forge

🎨 The DoSomething.org pattern library.

http://forge.dosomething.org

MIT License

48 stars 14 forks source link

Don't bundle jQuery with Forge. #539

Closed DFurnes closed 8 years ago

DFurnes commented 8 years ago

Changes

I had originally included this in the shared Webpack config, but we don't really want this behavior anywhere besides Forge. So I removed this from the shared config in v1.1 and added it in here. :hammer:

For review: @DoSomething/front-end

weerd commented 8 years ago

Does Forge require it for anything though? Cause if it does...

DFurnes commented 8 years ago

This removes it from the dist/forge.js bundle, so it can be "imported" like a Webpack module but still resolves to the window.jQuery object when not being used with a module bundler.

weerd commented 8 years ago

Gotcha. Cool :dancer: :+1: