search

DoSomething / gateway

:lock_with_ink_pen: An opinionated PHP REST API client.
MIT License
2 stars 0 forks source link

Fix old 'getUser' signature in RemoteUser. #127

Closed DFurnes closed 5 years ago

DFurnes commented 5 years ago

What's this PR do?

This includes a fix I'd missed in #126 to use the new getUser signature introduced in #125.

How should this be reviewed?

🌵

Checklist

katiecrane commented 5 years ago

So in https://github.com/DoSomething/gateway/pull/125 I'm seeing this: image so it doesn't look to me like the signature was changed in #125 to remove the first string parameter.

This change is still needed, I just don't think that's where it happened! Flagging on the off chance that this is important for some reason 🤷‍♀

DFurnes commented 5 years ago

You’re 100% right! The actual culprit for that change is #123.