DoSomething / gateway

:lock_with_ink_pen: An opinionated PHP REST API client.
MIT License
2 stars 0 forks source link

Fix unit tests #80

Closed sergiitk closed 7 years ago

sergiitk commented 7 years ago

What's this PR do?

How should this be manually tested?

./vendor/bin/phpunit

Any background context you want to provide?

While investigation #79, I've discovered that running ./vendor/bin/phpunit locally resulted in failure, while wercker pipeline was passing just fine. Then I discovered that wercker was complaining about missing php.ini:

https://app.wercker.com/dosomething/gateway/runs/build/598c7a2dc57cb3000150707f A php.ini file does not exist. You will have to create one.

I added wercker step that installs php.ini (based on 7.1.8 php.ini-development) to /usr/local/etc/php, as recommended in docker php documentation:

We recommend that you add a custom php.ini configuration. COPY it into /usr/local/etc/php by adding one more line to the Dockerfile above and running the same commands to build and run

With php.ini wercker started showing the same errors as local PHPUnit execution.

What are the relevant tickets?

Fixes #79.

sergiitk commented 7 years ago

Was able to reproduce the error on wercker!

DFurnes commented 7 years ago

Such a weird issue! Good investigating @sergii-tkachenko. 👀