Users seeming to not make it into gladiator from phoenix.
There were users in phoenix that had competition=1 on their signup record. This means they clicked "Join" on the competition prompt when they signed up for a campaign. There was a discrepancy between the number of people who joined a competition on phoenix and the number of people in competitions in gladiator
It was flagged over the summer that users were going missing from waiting rooms.
The Bug
The bug seems related to the splitting waiting room functionality. When an admin splits a waiting room we add them to a competition and then delete them from the waiting room.
The correct behavior is for the user to just be removed from the waiting room that got split.
Steps to Replicate
Put a user into two different open waiting rooms and then split one, you will notice that the user gets removed from both waiting rooms instead of just the one that got split.
Why This Matters
Because of this bug, people were not getting into competitions and therefore not receiving competitions messaging.
Update the logic of deleting a user from a waiting rooms to only delete the user from the waiting room that just got split. This should clear up most of what we are seeing and if there are other issues sill occurring, we can pinpoint those separately.
Other
We still should implement better monitoring in gladiator by getting it set up with Gateway so that we can track transaction ids of requests coming in and going out of the application.
We should still implement stathat monitoring of spikes in the system to alert the team when stuff is looking wonky.
We should still get better unit test coverage in the app.
BUG
Current Behavior
We have been noticing two different situations:
Users seeming to not make it into gladiator from phoenix. There were users in phoenix that had
competition=1on their signup record. This means they clicked "Join" on the competition prompt when they signed up for a campaign. There was a discrepancy between the number of people who joined a competition on phoenix and the number of people in competitions in gladiatorIt was flagged over the summer that users were going missing from waiting rooms.
The Bug
The bug seems related to the splitting waiting room functionality. When an admin splits a waiting room we add them to a competition and then delete them from the waiting room.
The bug is that we are deleting the users from all waiting rooms.
The correct behavior is for the user to just be removed from the waiting room that got split.
Steps to Replicate
Put a user into two different open waiting rooms and then split one, you will notice that the user gets removed from both waiting rooms instead of just the one that got split.
Why This Matters
Because of this bug, people were not getting into competitions and therefore not receiving competitions messaging.
This was happening at a rate of 5-15%
Proposed Fix
Update the logic of deleting a user from a waiting rooms to only delete the user from the waiting room that just got split. This should clear up most of what we are seeing and if there are other issues sill occurring, we can pinpoint those separately.
Other
We still should implement better monitoring in gladiator by getting it set up with Gateway so that we can track transaction ids of requests coming in and going out of the application.
We should still implement stathat monitoring of spikes in the system to alert the team when stuff is looking wonky.
We should still get better unit test coverage in the app.