DoSomething / gladiator

:guardsman: The DoSomething.org competitions platform.
2 stars 0 forks source link

Make sure all activity is showing in leaderboard/competition stats #398

Closed sbsmith86 closed 7 years ago

sbsmith86 commented 7 years ago

What's this PR do?

This PR fixes a bug where users with activity were not being included in the leaderboard or counted in the competition stats.

The issue was introduced when we moved to using the phoenix API directly instead of using the northstar proxy to grab signup data.

Phoenix returns data in an array with meta and data properties. We were grabbing signups by batches, and then trying to create a larger array of all the signup data with array_merge but we were not specifying that we needed the larger array to use the data property that had all the actual signup information.

This updates the code so that we return the correct data to the services that are trying to catalog and calculate leardboard info.

What are the relevant tickets?

Fixes #397