DoSomething / infrastructure

🐄 DoSomething.org's infrastructure, managed by Terraform.
MIT License
3 stars 2 forks source link

Replace 'acl' argument with boolean 'private', defaulting to true. #252

Closed DFurnes closed 4 years ago

DFurnes commented 4 years ago

What's this PR do?

This pull request replaces the existing acl option on S3 buckets with a boolean private option, defaulting to true. If this option is set, it will also use S3's Block Public Access feature to ensure we don't upload objects that are individually marked "public".

How should this be reviewed?

I'd recommend reviewing this without whitespace.

Any background context you want to provide?

I'm pulling #169216617 into this sprint because we keep getting warnings about these apps, and we'll want to keep this app's buckets but swap them to be safely private.

Relevant tickets

References Pivotal #173154671.

Checklist