This pull request will (hopefully!) fix up some issues I ran into when applying #257:
Error: Error creating IAM Role dosomething-bertly-dev-s3-fivetran: MalformedPolicyDocument: Syntax error at position (3,19)
status code: 400, request id: bb885527-9a87-44e5-a64c-bc57dc3b7a1b
I swapped this "role" from a JSON template (which I'd used for consistency with our other IAM policies) to a data object (following Morgan's lead in #250), since I can't otherwise see what could be amiss with the role document & there doesn't seem to be a way to inspect these in the AWS console, like IAM policies. 😩
I also realized I'd forgotten to make a aws_iam_role_policy_attachment to connect these two things (the policy that grants Fivetran access to this S3 bucket & the role that they use to access it). Whoops!
How should this be reviewed?
👀
Any background context you want to provide?
We may not use Fivetran's S3 connector after all (see ticket), but this allows us to test it out!
What's this PR do?
This pull request will (hopefully!) fix up some issues I ran into when applying #257:
I swapped this "role" from a JSON template (which I'd used for consistency with our other IAM policies) to a data object (following Morgan's lead in #250), since I can't otherwise see what could be amiss with the role document & there doesn't seem to be a way to inspect these in the AWS console, like IAM policies. 😩
I also realized I'd forgotten to make a
aws_iam_role_policy_attachmentto connect these two things (the policy that grants Fivetran access to this S3 bucket & the role that they use to access it). Whoops!How should this be reviewed?
👀
Any background context you want to provide?
We may not use Fivetran's S3 connector after all (see ticket), but this allows us to test it out!
Relevant tickets
References Pivotal #172652716.
Checklist