Add additional tags to AWS resources.

DFurnes commented 4 years ago

What's this PR do?

This pull request adds additional "tags" to AWS resources. These can be used to filter items in the web console (e.g. "show me all production databases") or CLI, or for analyzing our bill to see breakdown & trends by app.

I decided to start by categorizing our resources by:

Application (e.g. dosomething-northstar)
Environment (e.g. development or production)
Stack (e.g. web, backend, or data).

I'm open to better naming for that last one – the idea is to have a way to group different "domain contexts" so we can group different parts of our stack. I considered Context but it seemed nebulous, and Domain but figured it could be confused with a web domain.

And we can always adjust or add more tags in the future!

How should this be reviewed?

👀

Any background context you want to provide?

I know the diff looks scary, but it's all very straightforward changes!

Relevant tickets

References Pivotal #173665994.

Checklist

[ ] This PR has been added to the relevant Pivotal card.

weerd commented 4 years ago

Sounds good. Not fully convinced on Stack for the name since to me that has certain connotations in the programming world and is a bit confusing since something like Rogue is a backend stack but also has a web portal to interact with it... but nothing better comes to mind at the moment!

DFurnes commented 4 years ago

Not fully convinced on Stack for the name since to me that has certain connotations in the programming world and is a bit confusing since something like Rogue is a backend stack but also has a web portal to interact with it... but nothing better comes to mind at the moment!

Naming is hard! 🙈 If anything comes to mind later, definitely let me know!

Re: Rogue, I'm hoping we can break the admin panel out (into Aurora) for exactly that reason!

DoSomething / infrastructure