search

DoSomething / infrastructure

🐄 DoSomething.org's infrastructure, managed by Terraform.
MIT License
3 stars 2 forks source link

Fix some issues with new AWS tags. #261

Closed DFurnes closed 4 years ago

DFurnes commented 4 years ago

What's this PR do?

This pull request fixes some issues I noticed after applying #260 and reviewing resources in the AWS console:

📄 Fixes some unclear variable descriptions. 1343e3e

🚀 Adds tags to the "deploy buckets" that are used to deploy Lambda functions (previously untagged). 488cb3b

📛 Some S3, SQS, and Lambda resources have suffixes (like dosomething-northstar-low and dosomething-northstar-high queues). I've added a new application variable so these can be grouped as dosomething-northstar. 914c2c9

🏹 I've grouped all the (now deprecated) Longshot S3 buckets under a dosomething-longshot Application tag, rather than separate Application=longshot-hrblock, Application=longshot-footlocker, etc. 87ebde6

How should this be reviewed?

👀

Any background context you want to provide?

This is useful for reviewing AWS resources in the admin panel or billing views!

Relevant tickets

References Pivotal #173665994.

Checklist

katiecrane commented 4 years ago

So is the name like "Rogue" but the application would be like "dosomething-rogue"?

DFurnes commented 4 years ago

Yeah, I'm wondering if there's a better name (hah) for name now... here's some examples:

name application description
dosomething-northstar-low dosomething-northstar Northstar's low-priority SQS queue.
dosomething-northstar-high dosomething-northstar Northstar's high-priority SQS queue.
dosomething-graphql dosomething-graphql Our GraphQL Lambda function.
dosomething-graphql-webhook dosomething-graphql Our GraphQL Contentful webhook Lambda function.

So name is the specific thing (since sometimes applications will have more than one bucket, queue, or function), and application is the same for all resources in a given app, no matter how many there are.

katiecrane commented 4 years ago

Hmmm okay yeah I think I'm confused because in Heroku we have "pipeline" and "app" and here we have "name" and "application" but the AWS "name" corresponds to the Heroku "app" 😵 But that table is very helpful and given that I think this is good to go!

DFurnes commented 4 years ago

Oh – those are good points! I'd definitely be down for re-considering all this naming to be clearer across the board.

katiecrane commented 4 years ago

Would love to help think on that! Nothing super clear came to mind immediately (since "pipeline" doesn't really apply)

DFurnes commented 4 years ago

Let's keep mulling on it!