DoSomething / infrastructure

🐄 DoSomething.org's infrastructure, managed by Terraform.
MIT License
3 stars 2 forks source link

Don't block _all_ public access... #264

Closed DFurnes closed 4 years ago

DFurnes commented 4 years ago

What's this PR do?

I noticed a small issue after applying #263 - by blocking all public access, I'd accidentally blocked Papertrail as well! This pull request updates these rules to allow "public" bucket policies while still disallowing per-object public permissions.

How should this be reviewed?

:eyes:

Any background context you want to provide?

Here's documentation on this S3 feature and the associated Terraform resource.

Relevant tickets

References Pivotal #173253029.

Checklist