DoSomething / infrastructure

🐄 DoSomething.org's infrastructure, managed by Terraform.
MIT License
3 stars 2 forks source link

Create Fastly property as part of "static" app module. #271

Closed DFurnes closed 3 years ago

DFurnes commented 3 years ago

What's this PR do?

This pull request extracts assets.dosomething.org into its own Fastly property, inside the static application module. This makes it easier to then re-use a single "frontend" module between all three environments (since we only create assets.dosomething.org in production), and simplifies our production Fastly config (to reduce the chance of accidental errors)!

How should this be reviewed?

👀

Any background context you want to provide?

I'm going to follow this up with a similar PR to #270 which creates a single re-usable Fastly front-end module (for #165498108), and that in turn will make it nice and simple to add security headers for #173719273.

Relevant tickets

References Pivotal #174871199.

Checklist