Changing production backup retention to 7 days in prod

DoSomething / infrastructure

🐄 DoSomething.org's infrastructure, managed by Terraform.

MIT License

3 stars 2 forks source link

Changing production backup retention to 7 days in prod #284

Closed blisteringherb closed 3 years ago

blisteringherb commented 3 years ago

What's this PR do?

This pull request changes the backup retention period for production snapshots from 14 days to 7 days.

How should this be reviewed?

...

Any background context you want to provide?

...

Relevant tickets

References Pivotal #174829369.

Checklist

[x] This PR has been added to the relevant Pivotal card.

rapala61 commented 3 years ago

Hi @DFurnes, I'm not super familiar with Terraform, but have a question about this change. Do you remember if the change was actually deployed to Production? I see that our Quasar RDS continues to save 14 days vs the 7 days configured here. I wonder if there is another thing we need to do so it takes effect. Thanks in advance!

DFurnes commented 3 years ago

@rapala61 It looks like it wasn't! I've sent you over a Terraform Cloud invite, and you can see the pending plan for this workspace here. If everything looks good, just hit the "Confirm & Apply" button to apply that change in production.

rapala61 commented 3 years ago

@DFurnes I'm looking at the changes and it looks good as far as changing the backup retention from 14 to 7 days. However, it includes an additional change that looks a bit suspicious to me:

Prod postgres engine version: engine_version = "11.8" -> "11.4"
QA postgres engine version: engine_version = "11.8" -> "11.6"

This seems like a versioning pinning issue. I certainly don't intend to downgrade the engine. What do you suggest in this case?

DFurnes commented 3 years ago

Mmm, sounds like configuration drift! If that was an intentional change, let's reflect it in our configuration here and here.