search

DoSomething / infrastructure

🐄 DoSomething.org's infrastructure, managed by Terraform.
MIT License
3 stars 2 forks source link

Use same S3 bucket for Northstar & Rogue. #286

Closed DFurnes closed 3 years ago

DFurnes commented 3 years ago

What's this PR do?

This pull request moves Rogue's storage buckets into Northstar's application module (as we're combining these two codebases). I've already moved the files in each of Northstar's buckets into it's Rogue equivalent.

How should this be reviewed?

👀

Any background context you want to provide?

This allows Northstar to read/write uploads while continuing to access it's own files!

Relevant tickets

References Pivotal #176851342.

Checklist

DFurnes commented 3 years ago

Yeah, there shouldn't 🤞 be any changes from Rogue's perspective! We're just configuring them from "within" Northstar's module & now reading from that bucket in Northstar for OAuth keys (so we don't have to read & write to two different S3 buckets in Northstar).

katiecrane commented 3 years ago

@DFurnes perfect! Sounds like a good way to do it!