DoSomething / legacy-website

:moyai: The DoSomething.org legacy website.
https://www.dosomething.org/
MIT License
50 stars 22 forks source link

Add mGage integration into phoenix #5913

Closed mikefantini closed 8 years ago

mikefantini commented 8 years ago

We have mGage for UK, Brazil, and Mexico. We need to add this integration into drupal so that users in those countries are able to have a similar transactional text message experience as US users receive.

Ideally we could find a way to add these configurations to https://www.dosomething.org/admin/config/dosomething/opt_in for each country.

Something else to consider, I believe that currently as a Brazilian user when I register with my cell phone number the site is trying to add me to Mobile Commons. This isn't really a huge deal right now because Mobile Commons should just bounce those users. But ideally, we wouldn't be sending these users over to Mobile Commons at all.

@marahml @mshmsh5000 @DeeZone @sergii-tkachenko @angaither

Related:

marahml commented 8 years ago

Great, thanks @mikefantini! A couple of questions for the group:

Looping in @classicfreddie here too

deezone commented 8 years ago

@mikefantini The Message Broker mbc-registration-mobile app keys on user_country and application_id. The mobile number is added to the appropreate SMS service (Mobile Commons (2 accounts: US / CA) - mGage: 2 lists, MX / BR)) based on these two key values.

Logic that defines the current flow: https://github.com/DoSomething/mbc-registration-mobile/blob/master/src/MBC_RegistrationMobile_ServiceDirector.php#L50-L97

The mGage settings for CGG are currenty hard coded into the mbc-registration-mobile app (mbc-registration-mobile app: https://github.com/DoSomething/mbc-registration-mobile/blob/master/src/MB_mGage.php#L78-L88).

Addition to the Drupal app for mGage settings is different than the Mobile Commons requirements, the values should include:

@marahml Yes, last years CGG (not AGG as you inquired about above) have been imported to mGage lists.

marahml commented 8 years ago

@angaither thoughts on who best to take this on, on the Phoenix side?

sergiitk commented 8 years ago

I can take this if @angaither is OK with that.

angaither commented 8 years ago

:+1: I believe the bulk of this is already done, will just need an addtional op in field here https://www.dosomething.org/admin/config/dosomething/opt_in

angaither commented 8 years ago

@DeeZone can you explain what the opt_in_keyword is?

deezone commented 8 years ago

@angaither

I believe the bulk of this is already done

Details on what needs to be done: https://github.com/DoSomething/phoenix/issues/5939 The additional fields but adjustments in several other locations.

explain what the opt_in_keyword is?

A value mGage requires in addition to the opt_in_id value. Unlike Mobile Commons opt in which has a default keyword, mGage mimics the user sending an actual keyword to a shortcode.

angaither commented 8 years ago

is that per campaign? or do we have a default one that can get overridden per campaign?

A value mGage requires in addition to the opt_in_id value. Unlike Mobile Commons opt in which has a default keyword, mGage mimics the user sending an actual keyword to a shortcode.

deezone commented 8 years ago

Both the opt_in_id and opt_in_keyword (mGage) values should have a default value by country (MX/BR).

The default values could be overridden at the campaign level just like the current Mobile Commons setting. The campaign specific opt_in_id / opt_in_keyword settings should only be available in campaigns with MX/BR language versions.

Campaigns with a US English version should only have the opt_in_id setting (Mobile Commons), not opt_in_keyword.

global-en campaigns should not have opt_in settings. SMS (Mobile Commons / mGage) messaging outside of US, MX, BR and CA is not supported.

I suspect this is leading to a later global version having campaigns with different opt_in settings by language within the campaign. One campaign, several languages, different opt_in settings.

angaither commented 8 years ago

vNext