DoSomething / legacy-website

:moyai: The DoSomething.org legacy website.
https://www.dosomething.org/
MIT License
50 stars 22 forks source link

💯 Emoji RB Support #6167

Closed angaither closed 7 years ago

angaither commented 8 years ago

Adding emoji kills the reportback submission

image

submitting that returns a 404 for me.

I think this will require us to not use UTF-8 encoding in the db.

https://dosomethingorg1.zendesk.com/agent/tickets/149465 http://www.jeffgeerling.com/blogs/jeff-geerling/solving-emoji-problem-drupal-7

sheyd commented 8 years ago

@angaither Adding this in case (and I think we should for sanity of mind), change to actual UTF8 (i.e. utf8mb4) across the :globe_with_meridians: https://mathiasbynens.be/notes/mysql-utf8mb4

namimody commented 8 years ago
namimody commented 8 years ago

https://www.dosomething.org/admin/reportback/128124 -- dunno what those recycling signs are (emojis?), but interesting they show up in back end and in the caption on the front end...

angaither commented 8 years ago

closing because we can hope for better days in repo https://github.com/DoSomething/guardian

namimody commented 8 years ago

@angaither does it make sense to move this issue to the Quasar repo?

ngjo commented 8 years ago

hi @angaither -- @hbghidey and i were just talkinga bout this today! hannah was recreated this issue on mobile (full thread here: https://trello.com/c/vfFRBOiT/1602-users-hitting-404-page) but essentially, when someone submits a RB w/ an emoji over mobile, they get a 404 page and then when they hit back, they see the reportback gallery but then the submission button is gone

is there anything we can do to accept emojis (makes a lot of sense for mobile reporting back, especially), or should we add text in there that tells the user that they can't submit emojis?

angaither commented 8 years ago

yup, it's not just mobile, it's anytime emoji is submitted the reportback doesn't go through. but I'm not sure it makes sense to prioritize this issue in phoenix since we want to move reportbacks to rogue.

ngjo commented 8 years ago

Users hitting 404 page

jessleenyc commented 8 years ago

Would we be able to accept emojis in rogue? Thinking about how this is throwing off our 'pending' reportbacks count.

angaither commented 8 years ago

Thinking about how this is throwing off our 'pending' reportbacks count.

these reportbacks wouldn't be pending this is the problem where the reportback id exisits, and there's no file #6765

ngjo commented 8 years ago

yah -- no need to prioritize, but if that's the case -- i'll sync w/ @hbghidey to include that in the tech macro for the time being to help the member submit w/o emojis (sorrrrrriiieee, no fun emojis 🤑 for youuuuu!!!) thanks!

angaither commented 8 years ago

As a user, I would like to be able to submit an emoji with my reportback so that I can express myself without words (also so the system doesn't break).

mirie commented 7 years ago

We have emoji support in Phoenix-Next and Rogue. We will not be supporting emoji's in Phoenix-Ashes. We already are stripping out emojis from reportbacks per #7014.