DoSomething / legacy-website

:moyai: The DoSomething.org legacy website.
https://www.dosomething.org/
MIT License
50 stars 22 forks source link

Clean up warnings on reportback permalink page after submission #7236

Closed sbsmith86 closed 7 years ago

sbsmith86 commented 7 years ago

BUG

Current Behavior

When you submit a reportback you get a bunch of notices that look like this: screen shot 2016-12-07 at 11 06 44 am

Desired Behavior

We should not see so many.

There are three important ones to focus on.

  1. Notice: Undefined property: Reportback::$run_nid in dosomething_reportback_form_submit() (line 383 of /var/www/staging.beta.dosomething.org/releases/20161102161737/lib/modules/dosomething/dosomething_reportback/dosomething_reportback.forms.inc). Notice: Undefined property: Reportback::$uid in dosomething_reportback_form_submit() (line 383 of /var/www/staging.beta.dosomething.org/releases/20161102161737/lib/modules/dosomething/dosomething_reportback/dosomething_reportback.forms.inc).

Seems that these are most related to Rogue work. But it looks like @chloealee cleaned them up here and I confirmed I was not seeing them on my local or staging.

2. Notice: Undefined variable: why_participated_short in dosomething_reportback_view_entity() (line 602 of /var/www/staging.beta.dosomething.org/releases/20161102161737/lib/modules/dosomething/dosomething_reportback/dosomething_reportback.module).

3. Notice: Undefined variable: kudos in dosomething_reportback_view_entity() (line 603 of /var/www/staging.beta.dosomething.org/releases/20161102161737/lib/modules/dosomething/dosomething_reportback/dosomething_reportback.module).

Steps to Replicate

sbsmith86 commented 7 years ago

https://trello.com/c/gwz77ZBZ/149-2-as-a-developer-i-want-to-stop-getting-notices-on-phoenix-when-a-rb-is-submitted