In the above function, sometimes we successfully look up the user's Northstar ID but fail to return the actual Northstar user. In that case, the error printout is not helpful because it assumes it will be printing the drupal id (which is an integer) but then is given the Northstar ID, which is a string. It truncates the string when the letters start, often print out 58 for the id.
Desired Behavior
A different error printout if $id is the Northstar ID.
Steps to Replicate
I think this would happen in any case where we do get the Northstar ID but do not get the Northstar user.
Why This Matters
The current error printout is confusing because it's not what really happened.
ngjo
commented
7 years ago 
BUG
Current Behavior
Relevant function
In the above function, sometimes we successfully look up the user's Northstar ID but fail to return the actual Northstar user. In that case, the error printout is not helpful because it assumes it will be printing the drupal id (which is an integer) but then is given the Northstar ID, which is a string. It truncates the string when the letters start, often print out
58for the id.Desired Behavior
A different error printout if
$idis the Northstar ID.Steps to Replicate
I think this would happen in any case where we do get the Northstar ID but do not get the Northstar user.
Why This Matters
The current error printout is confusing because it's not what really happened.