search

DoSomething / legacy-website

:moyai: The DoSomething.org legacy website.
https://www.dosomething.org/
MIT License
50 stars 22 forks source link

Create node_modules dir in forge dir and cp node_modules/susy to this directory #7530

Closed mirie closed 6 years ago

mirie commented 6 years ago

What's this PR do?

Context:

We still have a build issue (issue with Forge and susy dependency):

alt text

From @DFurnes:

NPM 2.x nested node_modules within the modules that depended on the package. From 3.x onwards, dependencies are all flattened in a single node_modules directory. Unfortunately that path is inside a vendored forge.scss file, and we expect Webpack as our bundler in newer releases of Forge.

This fix creates the node_modules directory in the forge directory and copies over the susy directory to this location.

How should this be reviewed?

Hmmmm, untested because I can’t get a local build working! @_@

Relevant Tickets

https://github.com/DoSomething/devops/issues/406