DoSomething / tower

Ansible Tower Playbooks
MIT License
4 stars 8 forks source link

Change keyserver for nodejs key #221

Closed pnasrat closed 7 years ago

pnasrat commented 7 years ago

Fixes #220 by using ubuntu keyserver due to lack of SNI support.

What's this PR do?

Changes the keyserver to import the package signing key to be ubuntu keyserver due to unsupported SNI on the nodesource servers.

Where should the reviewer start?

How should this be manually tested?

You can change vagrant.yml:

diff --git a/vagrant.yml b/vagrant.yml
index 080331d..3012a6f 100644
--- a/vagrant.yml
+++ b/vagrant.yml
@@ -3,4 +3,4 @@
 - name: Setup vagrant
   hosts: all
   roles:
-    - { role: dosomething.vagrant }
+    - { role: dosomething.nodejs }

Run vagrant destroy && vagrant up

Observe successful run

changed: [default] => {"cache_update_time": 1490025344, "cache_updated": false, "changed": true, "stderr": "", "stdout": "Reading package lists...\nBuilding dependency tree...\nReading state information...\nThe following NEW packages will be installed:\n  nodejs\n0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.\nNeed to get 9947 kB of archives.\nAfter this operation, 50.5 MB of additional disk space will be used.\nFetched 9947 kB in 1s (5577 kB/s)\nSelecting previously unselected package nodejs.\n(Reading database ... 90713 files and directories currently installed.)\nPreparing to unpack .../nodejs_6.10.0-1nodesource1~trusty1_amd64.deb ...\nUnpacking nodejs (6.10.0-1nodesource1~trusty1) ...\nProcessing triggers for man-db (2.6.7.1-1ubuntu1) ...\nSetting up nodejs (6.10.0-1nodesource1~trusty1) ...\n", "stdout_lines": ["Reading package lists...", "Building dependency tree...", "Reading state information...", "The following NEW packages will be installed:", "  nodejs", "0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.", "Need to get 9947 kB of archives.", "After this operation, 50.5 MB of additional disk space will be used.", "Fetched 9947 kB in 1s (5577 kB/s)", "Selecting previously unselected package nodejs.", "(Reading database ... 90713 files and directories currently installed.)", "Preparing to unpack .../nodejs_6.10.0-1nodesource1~trusty1_amd64.deb ...", "Unpacking nodejs (6.10.0-1nodesource1~trusty1) ...", "Processing triggers for man-db (2.6.7.1-1ubuntu1) ...", "Setting up nodejs (6.10.0-1nodesource1~trusty1) ..."]}

PLAY RECAP *********************************************************************
default                    : ok=23   changed=19   unreachable=0    failed=0
blisteringherb commented 7 years ago

👍