DoSomethingArchive / gambit-content

:black_joker: Content API for Gambit
MIT License
2 stars 5 forks source link

Error Occurred Message Type + Alerts #902

Closed aaronschachter closed 7 years ago

aaronschachter commented 7 years ago

FEATURE OVERVIEW

User Story

As a member of the O'Doyle Family, I want members who are stuck in Campaign Conversation to receive a message that an error occurred and that we're looking into it. I also want:

Additional Information

We plan to send a custom header in the response to Blink to know whether to retry a response with status code 500, so we'll need a new Blink issue to check for it and retry accordingly once we're sending it through.

TODO:

Why This Matters

Users used to receive a "Whoops, an error occurred message" via Mobile Commons, when our chatbot mData would post to Gambit and get an error back.

Current behavior is that the user doesn't receive any message back at all, because Blink sends a success response to Mobile Commons indicating the message is queued. When Gambit responds with an error back to Blink, the user doesn't get a response back from us at all (and we wouldn't want them to receive 100 "An error occurred" messages for each Blink retry when the message is destined to fail).

aaronschachter commented 7 years ago

Blocked by https://github.com/DoSomething/blink/issues/71

sergiitk commented 7 years ago

@aaronschachter How about x-blink-suppress-retry: true instead?

aaronschachter commented 7 years ago

Sounds good, i'll update the description.

sergiitk commented 7 years ago

Actually, let's make it x-blink-retry-suppress: true to be more consistent with other x-blink-retry- headers.

sergiitk commented 7 years ago

Implemented in Blink in https://github.com/DoSomething/blink/pull/74.