search

DoTheEvo / selfhosted-apps-docker

Guide by Example
1.71k stars 122 forks source link

Typo #9

Closed maltokyo closed 4 years ago

maltokyo commented 4 years ago

In here:

https://github.com/DoTheEvo/selfhosted-apps-docker/tree/master/caddy_v2#--create-docker-composeyml

I guess MY_DOMAIN should be $MY_DOMAIN

DoTheEvo commented 4 years ago

one would think so, but test it... change it to $MY_DOMAIN or ${MY_DOMAIN} exec in to container using ctop and run printenv only plain works...

I guess it is some substitution or short form and in full it should be or whatever

environment:
  - MY_DOMAIN=$MY_DOMAIN

I might have know why and how it worked few months back, or I might have not... i dont remember now and quick google was not a success