DobyTang / LazyLibrarian

This project isn't finished yet. Goal is to create a SickBeard, CouchPotato, Headphones-like application for ebooks. Headphones is used as a base, so there are still a lot of references to it.
728 stars 72 forks source link

Opening multi-file audiobooks from GUI #1563

Closed BongoEADGC6 closed 5 years ago

BongoEADGC6 commented 5 years ago

To help with identifying and fixing issues, please include as much information as possible, including:

LazyLibrarian version number (at the bottom of config page)

73212dd3e444515487eb4674de465d40ffe8910e

Operating system used (windows, mac, linux, NAS type)

FreeBSD Jail

Interface in use (default, bookstrap)

Default

Which api (Goodreads, GoogleBooks, both)

Goodreads

Source of your LazyLibrarian installation (git, zip file, 3rd party package)

Git

Relevant debug log with api keys and any passwords redacted

When trying to use the "Open" button on an audiobook to download it, it only pulls a single file. Is this by design or how should this be handled?

Thanks

philborman commented 5 years ago

Should show a pop up with which piece to download, or a zip of them all, like this... screenshot from 2018-09-15 16-05-01 Do you get the popup on screen? If not it could be due to a missing or incorrect file. In each audiobook folder you should see a file called playlist.ll which is used to generate the popup. If the popup doesn't appear can you check if the playlist.ll file is there? Thanks.

BongoEADGC6 commented 5 years ago

There's no popups when clicking open.

My folder contains a bunch of mp3s, a jpg, and an off file. I don't see anything about a playlist. I'm guessing it wasn't generated in processing.

BongoEADGC6 commented 5 years ago

Here's an example of the log with one of the books

Timestamp   Level   Thread  File    Method  Line No Message
2018-09-15 11:50:55 DEBUG   AUDIOBOOK_SCAN  librarysync.py  LibraryScan 704 Found Language [eng] ISBN [9780765330420]
2018-09-15 11:50:55 DEBUG   AUDIOBOOK_SCAN  librarysync.py  LibraryScan 609 file meta [9780765330420] [eng] [Brandon Sanderson] [The Alloy of Law] [10803121]
2018-09-15 11:50:55 DEBUG   AUDIOBOOK_SCAN  librarysync.py  LibraryScan 542 [/media/books/audiobooks] Now scanning subdirectory /Brandon Sanderson/The Alloy of Law
2018-09-15 11:50:54 DEBUG   AUDIOBOOK_SCAN  librarysync.py  LibraryScan 957 Librarysync link to preferred part 01: /media/books/audiobooks/Brandon Sanderson/Shadows of Self/Brandon Sanderson - Shadows of Self 01-29.mp3
2018-09-15 11:50:54 DEBUG   AUDIOBOOK_SCAN  librarysync.py  find_book_in_db 198 Exact match [Shadows of Self]
2018-09-15 11:50:54 DEBUG   AUDIOBOOK_SCAN  librarysync.py  find_book_in_db 172 Searching database for [Shadows of Self] by [Brandon Sanderson]
2018-09-15 11:50:54 DEBUG   AUDIOBOOK_SCAN  librarysync.py  LibraryScan 716 Already cached Lang [eng] ISBN [076]
2018-09-15 11:50:54 DEBUG   AUDIOBOOK_SCAN  librarysync.py  LibraryScan 704 Found Language [eng] ISBN [9780765378552]
2018-09-15 11:50:54 DEBUG   AUDIOBOOK_SCAN  librarysync.py  LibraryScan 609 file meta [9780765378552] [eng] [Brandon Sanderson] [Shadows of Self] [16065004]
2018-09-15 11:50:54 DEBUG   AUDIOBOOK_SCAN  librarysync.py  LibraryScan 542 [/media/books/audiobooks] Now scanning subdirectory /Brandon Sanderson/Shadows of Self
philborman commented 5 years ago

Couple of things,

  1. The current code only generates a playlist when renaming the audio files, this is easily fixed and will be in the next release, probably later today. We should generate the playlist even if not renaming. Once you have upgraded, just go to the audiobook tab and choose "libraryscan" to check all the audio files and generate the playlists.
  2. We only generate a playlist if we can recognise all parts of the book. This could be a problem. Your filename for part 01 of the book is Brandon Sanderson - Shadows of Self 01-29.mp3 which is an unusual/ambiguous format, hopefully there are id3 tags in the files as that's our preferred source of info. If there are no id3 tags we try to get the part numbers from the filenames and can't be sure what this file is. Could be Shadows of Self book 1 chapter 29, or could be Shadows of Self chapters 1 to 29. Either way could cause issues. We need to recognise all the "parts" to generate a playlist, ie if there are 3 audio files in the folder we need the tracks to be numbered 1,2,3 and all the tracks should have the same author and title. You should see warnings in the log if that's not the case.
BongoEADGC6 commented 5 years ago

Maybe it's worth providing a way to intervene manually to create playlists if files are created in this fashion?

philborman commented 5 years ago

I think editing the audio file tags is the best solution, plenty of audio tag editors out there, not much point in duplicating their features in lazylibrarian. If the tags are correct we can easily create the Playlist, or you can do it manually with a text editor. The Playlist is just a list of filenames in the right order.

At the moment the tag library we use (tiny tag) is read-only. Similarly we read info from epub/mobi files but the libraries there are read-only too.

BongoEADGC6 commented 5 years ago

Looks like the last few commits made big changes to the audiobook playlists. I now get the popups you mentioned with part numbers or a zip.

I'll update with more information, if any aren't working.

Thanks for jumping on this so quickly. Very impressed.

On Sat, Sep 15, 2018 at 4:25 PM philborman notifications@github.com wrote:

I think editing the audio file tags is the best solution, plenty of audio tag editors out there, not much point in duplicating their features in lazylibrarian. If the tags are correct we can easily create the Playlist, or you can do it manually with a text editor. The Playlist is just a list of filenames in the right order.

At the moment the tag library we use (tiny tag) is read-only. Similarly we read info from epub/mobi files but the libraries there are read-only too.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DobyTang/LazyLibrarian/issues/1563#issuecomment-421629320, or mute the thread https://github.com/notifications/unsubscribe-auth/ALr2GxPaR2LUuR9hCypErURMq6gODM_pks5ubWI9gaJpZM4WqWHZ .

--

Cliff Hults