DobyTang / LazyLibrarian

This project isn't finished yet. Goal is to create a SickBeard, CouchPotato, Headphones-like application for ebooks. Headphones is used as a base, so there are still a lot of references to it.
732 stars 70 forks source link

GoodReads failing to find books that I know are on Goodreads because I can find them #1641

Closed mstrdraco closed 6 years ago

mstrdraco commented 6 years ago

To help with identifying and fixing issues, please include as much information as possible, including:

LazyLibrarian version number (at the bottom of config page) Current Version: a4fd6e6241cb9cb8427ffd732fa53a6abd13a68b

Operating system used (windows)

Interface in use (bookstrap)

Which api (Goodreads)

Source of your LazyLibrarian installation (git, zip file, 3rd party package) zip

Relevant debug log with api keys and any passwords redacted

debug.zip

I'm getting errors saying that it can't find books when I know the books are there because I can find them manually on good read and if I hit the Goodreads link it finds them plus they show up in my Database?

2018-10-25 09:38:19 WARNING Failed to match book [War of the Wilted] by [Amber Mitchell] in database
2018-10-25 09:38:19 WARNING GoodReads doesn't know about War of the Wilted
2018-10-25 09:38:19 WARNING Failed to match book [The Cruel Prince] by [Holly Black] in database
2018-10-25 09:38:19 WARNING GoodReads doesn't know about The Cruel Prince

Please note - usually a single line of log is not sufficient. The lines just before the error occurs can give useful context and greatly assist with debugging.

There is a built-in debug log creator on the logs page which makes it easy to provide this information

philborman commented 6 years ago

Debug log only shows an rss search, not the log lines you posted. Would need to see a debug log of the libraryscan section so we can see what happened just before the warning messages. The messages seem to show the books are not already in the database, and when we try a second attempt to query goodreads for them goodreads can't find the books. Could be a fuzzy mis-match on the title or maybe a preferences issue or a connectivity problem, or a bad xml page.

mstrdraco commented 6 years ago
2018-10-25 10:13:53 WARNING IMPORTALT postprocess.py processAlternate 117 No book file found in d:\wish\
2018-10-25 10:13:53 WARNING IMPORTALT postprocess.py processAlternate 200 eBook War of the Wilted (Garden of Thorns Series Book 2) by Amber Mitchell not found in database
2018-10-25 10:13:53 DEBUG IMPORTALT librarysync.py find_book_in_db 421 Fuzz failed [Amber Mitchell - War of the Wilted (Garden of Thorns Series Book 2)] ratio [46,War of the Wilted,37904177], partial [94,War of the Wilted,37904177], partname [94,War of the Wilted,37904177]
2018-10-25 10:13:53 DEBUG IMPORTALT librarysync.py find_book_in_db 255 Searching 2 books by [Amber Mitchell] in database for [War of the Wilted (Garden of Thorns Series Book 2)]
2018-10-25 10:13:53 DEBUG IMPORTALT librarysync.py find_book_in_db 172 Searching database for [War of the Wilted (Garden of Thorns Series Book 2)] by [Amber Mitchell]
2018-10-25 10:13:53 DEBUG IMPORTALT postprocess.py processAlternate 177 Author Amber Mitchell found in database
2018-10-25 10:13:53 DEBUG IMPORTALT postprocess.py processAlternate 131 No metadata file found for d:\wish(37904177)\War of the Wilted - Amber Mitchell.epub
2018-10-25 10:13:53 DEBUG IMPORTALT postprocess.py processAlternate 83 Processing eBook directory d:\wish(37904177)
2018-10-25 10:13:53 WARNING IMPORTALT postprocess.py processAlternate 200 eBook The Cruel Prince (The Folk of the Air Book 1) by Holly Black not found in database
2018-10-25 10:13:53 DEBUG IMPORTALT librarysync.py find_book_in_db 421 Fuzz failed [Holly Black - The Cruel Prince (The Folk of the Air Book 1)] ratio [54,The Darkest Part of the Forest,20958632], partial [93,The Cruel Prince,26032825], partname [93,The Cruel Prince,26032825]
mstrdraco commented 6 years ago

Oddly enough I've cleared the log and restarted debugging and it's still showing the same thing not showing any new details it's showing stuff from the 21st? hmmm

philborman commented 6 years ago

It's fuzzy matching. You are getting 94% and 93% matches on those two titles, and your config.ini settings are set to reject if less than 95%
Simple fix is to reduce your setting in config.ini name_partial to 93. It's the extra bit in brackets that's longer than normal. [War of the Wilted (Garden of Thorns Series Book 2)] is 100% match War of the Wilted, but 6 extra words, 100 - 6 = 94

mstrdraco commented 6 years ago

debug.zip I wiped out all logs and restarted lazy librarian and it looks to be logging properly now

mstrdraco commented 6 years ago

It's fuzzy matching. You are getting 94% and 93% matches on those two titles, and your config.ini settings are set to reject if less than 95% Simple fix is to reduce your setting in config.ini name_partial to 93. It's the extra bit in brackets that's longer than normal. [War of the Wilted (Garden of Thorns Series Book 2)] is 100% match War of the Wilted, but 6 extra words, 100 - 6 = 94

Sweet that fixed it thank you!