search

DobyTang / LazyLibrarian

This project isn't finished yet. Goal is to create a SickBeard, CouchPotato, Headphones-like application for ebooks. Headphones is used as a base, so there are still a lot of references to it.
730 stars 70 forks source link

Successful post processing not removing completed download from SABnzbd #859

Closed MrMxyzptlk closed 7 years ago

MrMxyzptlk commented 7 years ago

Successful post processing not removing completed download from SABnzbd

File being renamed, moved, and deleted correctly, just not removed from SABnzbd history. It also shows as processed in LL history.

philborman commented 7 years ago

I don't know whether SAB has a "delete from history" option. You can delete a failed/stalled task but not a completed one.

Just checked on SAB site, seems the SAB api will let you delete items from queue, but not from history. However, saw another post that says CouchPotato can do it, would need to look into how.

MrMxyzptlk commented 7 years ago

Yes, you can always manually delete any 'task' from in SABnzbd. I thought that LL automatically removed the completed task / job from SABnzbd when post processing?

LL is automatically removing completed tasks / jobs from Deluge.

philborman commented 7 years ago

LazyLibrarian only deletes entries from queue if failed. Doesn't touch completed history on any of the downloaders. Just found documentation where SAB does allow removal from history, so could add it. Will look if the other downloaders do too, and maybe make optional.

MrMxyzptlk commented 7 years ago

OK, awesome.

philborman commented 7 years ago

Seems the one "delete" operation works on deluge (remove from queue and also from history) , and works the same on nzbget, but SAB requires two separate commands. One to delete from queue, and another to delete from history. Not sure about the other downloaders yet. Next version will have the extra sab command in, but I can't test it (don't have a working sab atm) so if you could try with debug on and report back would be useful. Thanks.

MrMxyzptlk commented 7 years ago

Would be happy to test. Let me know when it's ready.

philborman commented 7 years ago

Just pushed it now, you should see messages in the debug log saying Request url for (something) LL(Delete) and another saying Request url for (something) LL(DelHistory) and each of those should have a Result text from SAB: (hopefully OK)

MrMxyzptlk commented 7 years ago

So I started some downloads for books, and they completed. Rather than wait for the auto post processing I ran a manual PP. It hung on the following during PP.

2017-06-15 07:32:32 ERROR Unhandled exception in processDir: Traceback (most recent call last): File "Z:\Applications\lazylibrarian\lazylibrarian\postprocess.py", line 360, in processDir if book_type == 'eBook' and not book_file(pp_path, 'ebook'): File "Z:\Applications\lazylibrarian\lazylibrarian\common.py", line 106, in book_file for fname in os.listdir(search_dir): WindowsError: [Error 3] The system cannot find the path specified: u'Z:\Applications\Downloads\Books\Finders Keepers (Bill Hodges Trilogy #2) by Stephen King \.' 2017-06-15 07:32:32 DEBUG Found folder (100%) Z:\Applications\Downloads\Books\Finders Keepers (Bill Hodges Trilogy #2) by Stephen King for eBook Finders Keepers (Bill Hodges Trilogy #2) by Stephen King .epub 2017-06-15 07:32:32 DEBUG Failed to copy/move file Finders Keepers (Bill Hodges Trilogy #2) by Stephen King .epub to Z:\Applications\Downloads\Books\Finders Keepers (Bill Hodges Trilogy #2) by Stephen King , [Errno 2] No such file or directory: u'Z:\Applications\Downloads\Books\Finders Keepers (Bill Hodges Trilogy #2) by Stephen King \Finders Keepers (Bill Hodges Trilogy #2) by Stephen King .epub' 2017-06-15 07:32:32 DEBUG Skipping Z:\Applications\Downloads\Books\Finders Keepers (Bill Hodges Trilogy #2) by Stephen King, folder is empty 2017-06-15 07:32:32 DEBUG Skipping Z:\Applications\Downloads\Books\Finders Keepers (Bill Hodges Trilogy #2) by Stephen King, no ebook found 2017-06-15 07:32:32 DEBUG Found folder (100%) Z:\Applications\Downloads\Books\Finders Keepers (Bill Hodges Trilogy #2) by Stephen King for eBook Finders Keepers (Bill Hodges Trilogy #2) by Stephen King .epub 2017-06-15 07:32:32 INFO Looking for eBook Finders Keepers (Bill Hodges Trilogy #2) by Stephen King .epub in Z:\Applications\Downloads\Books

philborman commented 7 years ago

Interesting. Your debug log looks to be out of order, so a little hard to follow, but it seems windows doesn't like the directory name. Either because it ends in a space character, or maybe the hash. Is # a valid character in a windows directory name? Either or both can easily be stripped. At the moment to create the directory name we just take the file name and strip the extension. Unfortunately in this filename there is a space between King and .epub which might be the cause, or as I said it could be the hash. I will have a play with directory names and see. Might be if you ask for a directory ending in a space windows refuses, or it strips the space for you?

MrMxyzptlk commented 7 years ago

Do not end a file or directory name with a space or a period. Although the underlying file system may support such names, the Windows shell and user interface does not. However, it is acceptable to specify a period as the first character of a name. For example, ".temp".

MrMxyzptlk commented 7 years ago

Here is the guide. https://msdn.microsoft.com/en-us/library/aa365247

MrMxyzptlk commented 7 years ago

Removing the space at the end of the filename is letting me continue the process.

philborman commented 7 years ago

ok, useful doc. Thanks for that. Seems hash is ok, it's just the space then. Badly named epub file with a space before the extension, just pushing a fix now...

MrMxyzptlk commented 7 years ago

So I see in LL where it is attempting deletion from SABnzbd. But it nevers deletes, and I don't see any indication in the SABnzbd logs that it's being attempted. Here is that log. sabnzbd.txt

And here is the log entry in LL... 2017-06-15 08:17:48 DEBUG Deleted James Patterson - Crazy House LL.(34102633), nzb from sabnzbd

philborman commented 7 years ago

That's the first delete, delete from queue, there should be a second called delhistory which runs just after the first one. Do you also have the message saying "result from sab" as if the first one fails maybe the second doesn't run?

On Thu, 15 Jun 2017, 16:57 MrMxyzptlk, notifications@github.com wrote:

So I see in LL where it is attempting deletion from SABnzbd. But it nevers deletes, and I don't see any indication in the SABnzbd logs that it's being attempted. Here is that log. sabnzbd.txt https://github.com/DobyTang/LazyLibrarian/files/1078027/sabnzbd.txt

2017-06-15 08:17:48 DEBUG Deleted James Patterson - Crazy House LL.(34102633), nzb from sabnzbd

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/DobyTang/LazyLibrarian/issues/859#issuecomment-308759788, or mute the thread https://github.com/notifications/unsubscribe-auth/ALmHOd6wdyt0gc1Ia6GOWTKrCcPSXe-Lks5sEUZWgaJpZM4N6EXj .

MrMxyzptlk commented 7 years ago

I just did another search and download. I will let you know in the next day or 2 what the results are.