search

DocCyblade / tkl-odoo

Turnkey Linux - Odoo v8 (Published v14.2)
https://www.turnkeylinux.org/odoo
GNU General Public License v3.0
21 stars 24 forks source link

plan uses incorrect comment marker #14

Closed JedMeister closed 9 years ago

JedMeister commented 9 years ago

I notice that the plan uses # for comments. Whilst the plans are just text files, technically they are actually C files. The C pre-processor DOES NOT treat # as a comment! You need to enclose comments in /* and */ e.g. WordPress appliance.

Now what impact it's actually been having I'm not really sure. TBH I would have expected it to be causing errors. But obviously nothing hugely significant. At the very least though I would expected it to stop any packages with comments (starting with #) from installing. But I imagine that you would have noticed that too!

JedMeister commented 9 years ago

FWIW this is the sed regex I used: s|# *$||; s|# |/* |; /\/\*/ s/$/ \*\//

DocCyblade commented 9 years ago

@JedMeister I wondered what was the correct way. I found the # works only after the statement. The build does not fail. But good to know what the correct way to comment is. I wanted to comment a little more, group them packages. If you have seen I like well documented files, if not for others sake for my own if I go back 3 months and try to figure out what I was doing!

DocCyblade commented 9 years ago

15 closes this

JedMeister commented 9 years ago

:+1: