Closed JedMeister closed 8 years ago
DocCyblade
commented
8 years ago Is this one of the 'unwritten rules" you spoke of?
So if we base another app off another such as lapp in the future, just mention core and, what is considered special changes? Such as Adminer and SSL Harding? I saw this in another app change log. That now makes sense to me why they had that in there.
DocCyblade
commented
8 years ago Looks good to me, @l-arnold I'll let you take a look as well and comment
JedMeister
commented
8 years ago Is this one of the 'unwritten rules" you spoke of?
Yeah seems so... :smile:
You could certainly add mention of Adminer...
DocCyblade
commented
8 years ago Well if this is the first release, and we do say it's built on Lapp, that's implied. The next version we would include anything special that changed in LAPP along with. Makes sense to me now. I'll leave it as is
l-arnold
commented
8 years ago This looks fine. I will add however that my original start came from "tklcarlos" , ie on github CLVsol/tkl-odoo
Carlos made a strong effort on this and diverted into making Patches where he could Mod a Cloud install of Lapp for instance.
He did some great work. I did try a few times to get him to come in on this but did not hear back.
DocCyblade
commented
8 years ago @l-arnold did he help you with your repo? I did not see any commits by him?
l-arnold
commented
8 years ago No. However my "starting" code base came from him. He had actually pointed me towards his "patch system" but I found the other repository and it looked like more the direction. I didn't "fork" per say. Just used it as a base. We did "linkin" the other day and I expect he would come in once this goes into the library. He does some very interesting work. Mostly focused towards the medical industry.
Certainly comfortable w/ a citation his way. It is in my original "readme" for sure..
DocCyblade
commented
8 years ago I'm OK to add him if you would like just let me know
l-arnold
commented
8 years ago Why don't we say Inspired by the original efforts of Carlos Vercelino on Github at: CLVsol/tkl-odoo
DocCyblade
commented
8 years ago Sounds good. I'll approve the request and then make the changes
I just tweaked the changelog.
The first bit is only suggested. I just thought a slightly different layout might work better.
Also happy for you guys to have all the glory for this build. I've only given advice/opinion mostly (and been a PITA no doubt! :stuck_out_tongue: )
Re removal of the reference to LAPP changelog: I totally get where you're coming from and that would be my preference too but Alon decided that all the apps just reference Core and make individual note of any special changes in LAMP/LAPP so this keeps it consistent with the other appliances...