Better complex fields.

[yajo]

Some improvements:

• @api.one is deprecated. Using @api.multi.
• Use of placeholders.
• Onchange methods usually should raise warnings instead of returning them.
• New api onchange methods cannot return values. They set them in self.
• You can delete unwanted sections for computed fields snippet.
• Proper indentation.

[DocMarty84]

Thanks a lot! Some remarks:

Onchange methods usually should raise warnings instead of returning them

I don't agree. Returning warnings in an onchange is actually the only non-blocking warning tool available in Odoo, so I would keept it. Moreover, I would keep vals['domain'] and vals['warning'], and return vals, for clarity.

[yajo]

What do you mean by "non-blocking warning tool"?

[DocMarty84]

What do you mean by "non-blocking warning tool"?

A raise will stop the execution of the Python code, and do a rollback. On the other hand, when you return a warning, it will just display a pop-up and continue the execution of the Python code. In an onchange, you usually don't want to trigger a raise.

[yajo]

Well actually AFAIK in onchanges, Wanings have special behavior in onchanges. I think they serve to stop execution, while the returned value is for not stopping it, but I'm not sure, but since this is just a snippet, I'll add it.