search

DocMarty84 / miniflutt

Another Miniflux client.
MIT License
115 stars 16 forks source link

Add favicon #4

Closed dani closed 2 years ago

dani commented 3 years ago

Just tried miniflutt. It's the only app I tried which could get me connected to my miniflux instance so far (I'm using OIDC auth), so, first : great that you chose to use an API key instead of login/pass. One thing I miss is the favicon of the various site in the app, to quickly see where the article is coming from (yes, it's written just under the article title, but a favicon would make it far easier to identify)

Cheers, Daniel

DocMarty84 commented 3 years ago

Hello,

So you mean the favicon in the list of articles? Or maybe also in the drawer (left panel)?

dani commented 3 years ago

Mainly in the list of articles, but yeah, also in the left paneel

DocMarty84 commented 3 years ago

At this point I'm a bit struggling with Flutter to do this... The miniflutt API only returns a base64 image, but the Flutter widget Image.memory(base64Decode(...)) keeps causing problems in the app. I can't figure out why.

I added to the miniflux API a route to return the binary favicon (https://github.com/DocMarty84/v2/commit/2daa6067ad0dbdeea77d73accf562de29118d652), and this way I'm able to have something that could work: Capture du 2021-03-20 17-57-25 Capture du 2021-03-20 17-57-42

However, not sure the Miniflux dev team will accept such a change... I'll keep you informed.

DocMarty84 commented 2 years ago

Won't fix, sorry :-(