search

DocNow / diffengine

track changes to the news, where news is anything with an RSS feed
MIT License
177 stars 30 forks source link

pip 19 breaks install #57

Closed maehr closed 4 years ago

maehr commented 4 years ago

Because of https://github.com/pypa/pip/issues/4187 --process-dependency-links is not supported anymore and installation fails. Use pip3 install --upgrade pip==18.0.0 to install it.

edsu commented 4 years ago

I actually forgot about --process-dependency-links when I was re-creating my environment with pip v19.3.1. I noticed that I get a build error about failing to remove htmldiff's build directory:

ERROR: Failed cleaning build dir for htmldiff

... but that the tests pass just fine, as they also do on Travis (which doesn't do --process-dependency-links).

So I wonder if we can remove that part of the diffengine documentation?

maehr commented 4 years ago

I failed to install it via pip3 install --process-dependency-links diffengine on osx 10.14.6 and python 3.7.5. (And I guess travis does not use the latest pip version.) Shall I investigate further?

edsu commented 4 years ago

Sorry, I guess I wasn't clear. Try without the --process-dependency-links.

maehr commented 4 years ago

That didn't work either.

Collecting htmldiff==0.2 (from diffengine)
  Could not find a version that satisfies the requirement htmldiff==0.2 (from diffengine) (from versions: 0.1)
No matching distribution found for htmldiff==0.2 (from diffengine)
edsu commented 4 years ago

Oh, I was actually doing a pip install -r requirements.txt which is what Travis does as well. But this isn't useful for people who don't have a git clone of the repo--which is most people.

edsu commented 4 years ago

Maybe this is tilting at windmills, but the solution I'd like to aim for here is to get htmldiff in shape so it can be installed properly.

maehr commented 4 years ago

Tell me how I can help you to fix htmldiff.

edsu commented 4 years ago

diffengine usings python3 and there was a small problem with htmldiff that prevented it from running on python3 https://github.com/edsu/htmldiff/commit/a2ae66bbb952272d5f18be8b5c4c7b38588acd6e

If that problem has been fixed upstream diffengine's requirements can just be pointed at that, and I believe --process-dependency-links can go away. Would you be willing to check on that?

maehr commented 4 years ago

@mitsuhiko can you release a new version to the PyPi repo https://pypi.org/project/htmldiff/ ? @edsu I guess this would fix the problem?

edsu commented 4 years ago

Yes, it does look like the python3 support was merged, but it was never pushed to PyPI. I guess I can open a ticket on the htmldiff repository to ask for a new release. I'm not sure @mitsuhiko will notice it here...

maehr commented 4 years ago

@edsu how about integrate the htmldiff source directly? For the license check https://github.com/mitsuhiko/htmldiff/blob/master/LICENSE

weitzman commented 4 years ago

Still broken, fyi.

edsu commented 4 years ago

@weitzman it would be helpful if you could also comment over on https://github.com/mitsuhiko/htmldiff/issues/7 to try to move this along without us forking or copying the code.

edsu commented 4 years ago

This has gone on long enough. I guess we'll just fork it.