search

DocNow / diffengine

track changes to the news, where news is anything with an RSS feed
MIT License
177 stars 30 forks source link

Tweeting fix #84

Closed nahuelhds closed 4 years ago

nahuelhds commented 4 years ago

This fix recovers the ability to start a thread lost at #77 after the change made by @andresfib of the default value from None to '' for the tweet_status_id_str columns.

@andresfib is this change actually needed? I don't see you use that column in your PR at all. Anyway, I've already change it to make it work again.

In the other hand, I've addede the magic props of url_changed, title_changed, summary_changed that I forgot to add to the Diff model. Those are used when all the lang terms are defined in order to build the text properly. I've just realized about that omission 🤦‍♂️

Side note

It also includes a Travis CI fix as chrome stable version is now 83 and chromedriver at apt-get was 81 so I found a way to install the proper version in order for the CI to work again

andresfib commented 4 years ago

@nahuelhds , sorry for the mess after changing the default value.

I don't recall exactly, but I believe I changed it because peewee? was complaining that tweet_status_id_str is not initialized when not using twitter to publish diffs.

nahuelhds commented 4 years ago

@nahuelhds , sorry for the mess after changing the default value.

I don't recall exactly, but I believe I changed it because peewee? was complaining that tweet_status_id_str is not initialized when not using twitter to publish diffs.

Weird. That was why I initially used the null=True definition. Anyway, now it follows your change and looks for tweet = '' and then creates the thread :)

nahuelhds commented 4 years ago

@edsu this one is ready to be merged