search

DocOps / asciidocsy-jekyll-theme

Jekyll/AsciiDoc port of Docsy theme for scalable technical documentation projects
https://asciidocsy.netlify.app/docs
Apache License 2.0
9 stars 9 forks source link

Seeking help with Bootstrap-related bug #40

Closed briandominick closed 3 years ago

briandominick commented 3 years ago

This branch is not ready for merge at this time. I'm just stuck on something that I need to step away from and thought someone might want to take a look at it.

The feature is a tab-panel set, based on Bootstrap's component for handling this. You can see it demonstrated on the PR staging site: https://deploy-preview-40--asciidocsy.netlify.app/docs/theme/config/versioning/tabsets

Bootstrap's documentation (and elsewhere) says the tabs and target panes need IDs that refer to each other, but I have found this is not true. In fact, it should work with no IDs, as long as the target panes have a unique class and you link to that class as href=".classname". I saw this suggested on StackExchange and gave it a try, and it sort-of works.

The demo page has 2 nearly identical tabsets, with the same tab and pane classes. The tabs on both tabsets control the panes on only the first tabset. The intended behavior is that when you make a choice among identical options, all tabsets will change.

I removed the IDs from my elements and am using classes. The jQuery that converts my HTML to Bootstrap's format isn't too important -- I can make it form the HTML as we need, but I can't figure out what that is.

briandominick commented 3 years ago

Never got any help. Solved it my damn self. PR incoming...