search

DocOtak / gsw-xarray

Wrapper for gsw that will add CF attributes to xarray.DataArray outputs
https://gsw-xarray.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
23 stars 3 forks source link

add flake8 in pre-commit #54

Closed rcaneill closed 1 year ago

rcaneill commented 2 years ago

closes #13

rcaneill commented 2 years ago

linting is now moved to lint.yml, but I don't know why it is not ran by the github actions... I'll try to fix this later

rcaneill commented 2 years ago

As far as i remember, this is ready to be reviewed / merged

DocOtak commented 2 years ago

There are lots of file changes, is that due to black? All these changes might cause a little difficulty with #53

p.s. I move on board the ship today, connectivity might be a little flaky

rcaneill commented 2 years ago

I don't recall exactly but I guess that yes it is because of black. We can merge #53 first, and I'll create a new branch from master, and add the .yml files. May be the simplest