search

DocOtak / gsw-xarray

Wrapper for gsw that will add CF attributes to xarray.DataArray outputs
https://gsw-xarray.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
23 stars 3 forks source link

Add citation #67

Closed rcaneill closed 1 year ago

rcaneill commented 1 year ago

This PR adds citation of upstream gsw, cf https://github.com/TEOS-10/GSW-Python/issues/144 It also adds zenodo DOI

Also closes #66

rcaneill commented 1 year ago

Okay it seems that the poetry.lock packages do not work well with python 3.11 I'll close this PR and reopen a new one when PR #53 is merged (will be easier than updating this PR)

DocOtak commented 1 year ago

How do you feel about poetry? Does it get in the way too much?

rcaneill commented 1 year ago

How do you feel about poetry? Does it get in the way too much?

I think that poetry is fine. From the user point of view, it is working very well. From the devs point of view, it sometimes needs some adjustments to verify that all dependencies are still working with newer python versions (of newer versions of other packages). I think that the problem is not poetry itself, but simply that sometimes the packages are not fully correct regarding the supported versions of their own requirements.

Overall my opinion is that poetry is good for this project.