search

DocSpring / craco-antd

A craco plugin to use Ant Design with create-react-app
MIT License
234 stars 49 forks source link

Upgrade to craco@7.1.0 #117

Closed vKongv closed 9 months ago

vKongv commented 1 year ago

craco does not support react-scripts 5.x in 6.x version. We need to update to 7.x version in order to properly support this. This peer-dependency doesn't make sense as it's conflicting with craco.

vKongv commented 1 year ago

Hey @ndbroadbent , would you mind to review this PR and see if there's any issue? We are having major blocker due to peer dependency.

abenhamdine commented 1 year ago

@vKongv did you make some tests with your PR ? is it working fine to build a CRA 5 project ?

BryceBlankinship commented 1 year ago

Can someone please merge this? @vKongv is right about the peer dep making no sense. We are relying on this in a corp environment and I have to fork and make the change myself in order to get it up and running today but would like to use the official repo not my own.

EDIT: theres actually an issue with this PR if craco-less doesn't get craco v7.1.0 support first. Make the change there first before approving this.

vKongv commented 1 year ago

@BryceBlankinship Yeah, still waiting this to merge: https://github.com/DocSpring/craco-less/pull/106

kamronbatman commented 1 year ago

Sorry for the delay everyone. Once I test craco-less next week, I'll look into this update. Thanks!

Clafouti commented 1 year ago

Hi!

Is this PR still on the planning?

fnogatz commented 1 year ago

Sorry for the delay everyone. Once I test craco-less next week, I'll look into this update. Thanks!

This week, craco-less v3.0.0 was published which adds support for craco v7.1. Maybe a perfect opportunity to look into this MR again, @kamronbatman? 😺

kamronbatman commented 1 year ago

Sorry for the delay everyone. Once I test craco-less next week, I'll look into this update. Thanks!

This week, craco-less v3.0.0 was published which adds support for craco v7.1. Maybe a perfect opportunity to look into this MR again, @kamronbatman? 😺

I have been busy again sorry. I'll try to make some time this weekend to address the PR and update everything. Sorry for the delays!

makivlach commented 9 months ago

Could you, guys, proceed? 😄

BryceBlankinship commented 9 months ago

in the whole time this took we migrated half of our apps to a different build system XD

kamronbatman commented 9 months ago

This was already done. I'll work on bumping all dependencies and updating the test-app. Hopefully it isn't too much of a pain in the butt.

semihher commented 8 months ago

I can see craco@7.1.0 on master, but not on the published version on NPM. Are there any plans on uploading it?

kamronbatman commented 8 months ago

Good call, I thought it was published. 🙈 - I'll try to publish it this week.

vKongv commented 7 months ago

Thanks for doing this :)

ronfogel commented 7 months ago

@kamronbatman was it published? because I see that the latest version is 2 from 2 years ago

kamronbatman commented 7 months ago

Sorry, I didn't have time to publish over the weekend (I have to be on a specific computer to do it). I'll try to take care of it tonight! :) I'll also bump dependencies before I do it too.