search

DocSpring / craco-antd

A craco plugin to use Ant Design with create-react-app
MIT License
234 stars 49 forks source link

Pin craco-less to < 1.17.0 #34

Closed daniel-hauser closed 4 years ago

daniel-hauser commented 4 years ago

Fixes https://github.com/DocSpring/craco-antd/issues/33

ndbroadbent commented 4 years ago

Hello, thanks a lot for the PR!

It looks like there are some security vulnerabilities in the current yarn.lock. I would also really appreciate your help if you could please help me update these packages. Thanks a lot for your help!

There is also another PR (#35) that seems to add support for the latest less version.

ndbroadbent commented 4 years ago

Hello, thanks again for your help! I've updated craco-less and the less loader to the latest versions, and the changes have been pushed to craco-antd version 1.15.0

daniel-hauser commented 4 years ago

@ndbroadbent can you please reopen this PR?

I'll also really appreciate it if you merge it - as my production builds are failing.

Ill open a separate PR for the upgrading of (unrelated to the #33 issue) packages

aitsvet commented 4 years ago

Why pin to older version, let's correct this: https://github.com/DocSpring/craco-antd/pull/37