search

DocSpring / craco-antd

A craco plugin to use Ant Design with create-react-app
MIT License
234 stars 49 forks source link

Pin craco-less to < 1.17.0 #36

Closed daniel-hauser closed 4 years ago

daniel-hauser commented 4 years ago

This PR is a duplicate of #34 (that was closed when #33 closed)

In addition, ran yarn upgrade so now yarn audit passes

Thanks for helping to maintain craco-antd!

Before you submit this PR, please check the following:

jest --coverage --testPathIgnorePatterns test-app
yarn prettier --write "**/*.{js,jsx,json,css,scss,html,md,yml}"
yarn eslint --fix --ext .js lib/
yarn audit

You are also welcome to add your GitHub username to the Contributors section at the bottom of this README. (optional)

Please don't submit this pull request if it does not meet the above requirements.

aitsvet commented 4 years ago

Why pin to older version, let's correct this: https://github.com/DocSpring/craco-antd/pull/37

ndbroadbent commented 4 years ago

Thanks a lot, sorry about the difficulties!

daniel-hauser commented 4 years ago

@aitsvet This PR is a hotfix to allow dependants to build without errors, after that its a great idea to fix the code to use the new API

ndbroadbent commented 4 years ago

Released in version 1.16.0. I will also merge #37 now to update less