search

DocSpring / craco-antd

A craco plugin to use Ant Design with create-react-app
MIT License
234 stars 49 forks source link

Since version 1.17, only modifyVars allows to modify less variables #39

Closed abenhamdine closed 4 years ago

abenhamdine commented 4 years ago

Since version 1.17, less variables specified in files antd.customize.json, antd.customize.less or directly in customizeTheme does not seem to work.

Only lessLoaderOptions.modifyVars works.

Tested with craco-antd 1.17, craco-less 1.16, antd 4.3.0

ndbroadbent commented 4 years ago

Hello, can you please try updating craco-less to version 1.17? This should resolve the issue since it uses some new loader options

ndbroadbent commented 4 years ago

The other option is to downgrade craco-antd to version 1.16

abenhamdine commented 4 years ago

Hello, can you please try updating craco-less to version 1.17? This should resolve the issue since it uses some new loader options

Thx, I will give a try. But then shouldn't craco-antd be updated to use craco-less 1.17 rather than 1.16 ?

ndbroadbent commented 4 years ago

Hello, oh sorry about that, I think it was still using the wrong version of craco-less. Please try craco-antd 1.18.0 and this should be fixed now. Thanks!

abenhamdine commented 4 years ago

No problem, and thx a LOT !