search

DocSpring / craco-antd

A craco plugin to use Ant Design with create-react-app
MIT License
234 stars 49 forks source link

allow babel-plugin-import options modification #50

Closed DavidNorena closed 3 years ago

DavidNorena commented 3 years ago

Thanks for helping to maintain craco-antd!

Before you submit this PR, please check the following:

jest --coverage --testPathIgnorePatterns test-app
yarn prettier --write "**/*.{js,jsx,json,css,scss,html,md,yml}"
yarn eslint --fix --ext .js lib/
yarn audit

You are also welcome to add your GitHub username to the Contributors section at the bottom of this README. (optional)

Please don't submit this pull request if it does not meet the above requirements.

DavidNorena commented 3 years ago

fix for #49

ndbroadbent commented 3 years ago

Thanks a lot, this looks great! Unfortunately it looks like there are some security warnings I need to fix on the master branch, but otherwise everything looks good here

ndbroadbent commented 3 years ago

I've merged it in, but I will try to fix all the security warnings first before I push out a new version. (hopefully I can do it this weekend)

ndbroadbent commented 3 years ago

I've just upgraded react-scripts and all of the other NPM packages to the latest versions and fixed all those security warnings. I've released these changes in version: 1.19.0. Please try that out and let me know if you run into any issues!