Fix to support converting on Windows

DocSpring / libreconv

Ruby gem that converts office documents to PDF using LibreOffice / OpenOffice.

MIT License

198 stars 63 forks source link

Fix to support converting on Windows #26

Closed nthachus closed 4 years ago

nthachus commented 4 years ago

Remove unnecessary file Gemfile.lock
Reformat unit-test file to pass rubocop styles
Change hard-coded /tmp/ path into dynamic one, and use ENV SystemRoot, TEMP while executing Open3 sub-process to make convert method work on Windows

ndbroadbent commented 4 years ago

Looks good, thanks!

ndbroadbent commented 4 years ago

I've released these changes in 0.9.4. Thanks for your PR!

nthachus commented 4 years ago

You're welcome :-D

On Fri, Oct 4, 2019, 19:22 Nathan Broadbent notifications@github.com wrote:

I've released these changes in 0.9.4. Thanks for your PR!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DocSpring/libreconv/pull/26?email_source=notifications&email_token=ABCET6UNWPZIHEZWBUJI6C3QM4YQXA5CNFSM4I5OW56KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEALPBOY#issuecomment-538374331, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCET6QXORQQUQWCTQ2HGCLQM4YQXANCNFSM4I5OW56A .