Docile-Alligator / Infinity-For-Reddit

A Reddit client for Android
https://play.google.com/store/apps/details?id=ml.docilealligator.infinityforreddit
GNU Affero General Public License v3.0
4.26k stars 410 forks source link

Backing out of a comment before it loads will crash the app. #1532

Open syboxez opened 1 year ago

syboxez commented 1 year ago

Checklist

App version

6.0.4

Where did you get the app from

Other

Android version

13

Device model

OnePlus ONEPLUS A6003

First occurred

No response

Steps to reproduce

  1. Click on a comment
  2. Before it finishes loading, press the back button.

May take a few tries to get it to crash

Example post, link, markdown...

No specific post/comment. Also happens on downstream Lemmy fork.

Relevant downstream issue: https://codeberg.org/Bazsalanszky/Infinity-For-Lemmy/issues/138

Expected behaviour

I expect no crash

Current behaviour

Crashes to homescreen.

Logs

`` Stacktrace ``

java.lang.IllegalArgumentException: You cannot start a load for a destroyed activity
    at com.bumptech.glide.manager.RequestManagerRetriever.assertNotDestroyed(RequestManagerRetriever.java:348)
    at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:148)
    at com.bumptech.glide.Glide.with(Glide.java:826)
    at ml.docilealligator.infinityforreddit.adapters.CommentsRecyclerViewAdapter.<init>(CommentsRecyclerViewAdapter.java:169)
    at ml.docilealligator.infinityforreddit.fragments.ViewPostDetailFragment$13$1.onParsePostSuccess(ViewPostDetailFragment.java:1309)
    at ml.docilealligator.infinityforreddit.post.ParsePost.lambda$parsePost$0(ParsePost.java:95)
    at ml.docilealligator.infinityforreddit.post.ParsePost$$ExternalSyntheticLambda3.run(Unknown Source:4)
    at android.os.Handler.handleCallback(Handler.java:942)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loopOnce(Looper.java:201)
    at android.os.Looper.loop(Looper.java:288)
    at android.app.ActivityThread.main(ActivityThread.java:7924)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
    at com.android.internal.os.ExecInit.main(ExecInit.java:48)
    at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
    at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:355)

`` END of stacktrace ``

`` Thread info ``

Name: main
ID: 2
State: RUNNABLE
Priority: 5
Thread group name: main
Thread group parent: system
Thread group active count: 85
Thread time: 0 hr 0 min, 7 sec

`` END of thread info ``

`` Exit reasons ``

N/A

`` END of exit reasons ``

`` Application info ``

App name: Infinity
Version code: 123
Version name: 6.0.4
Package name: ml.docilealligator.infinityforreddit
Short package name: infinityforreddit
Flavor: N/A
Signatures: XFN80TR5rgSMbsH+WZ5oyxarmIU=
Is debuggable: No
First installed: 18-08-2023 15:21:46
Last updated: 18-08-2023 15:21:46
Requested permissions: android.permission.ACCESS_NETWORK_STATE, android.permission.INTERNET, android.permission.SET_WALLPAPER, android.permission.SET_WALLPAPER_HINTS, android.permission.FOREGROUND_SERVICE, android.permission.WAKE_LOCK, android.permission.POST_NOTIFICATIONS, android.permission.USE_BIOMETRIC, android.permission.USE_FINGERPRINT, android.permission.RECEIVE_BOOT_COMPLETED, ml.docilealligator.infinityforreddit.DYNAMIC_RECEIVER_NOT_EXPORTED_PERMISSION, android.permission.OTHER_SENSORS
Default prefs: N/A
Default prefs: N/A

`` END of Application info ``

`` Currently running foreground/background processes ``

N/A

`` END of running foreground/background processes info ``