Patreon login with google disabled

arvenyon commented 5 months ago

Checklist

[X] I have used the search function for open and closed issues to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.
[X] If the bug only occurs with a certain link, post, image..., I will include the URL.

App version

7.1.1

Where did you get the app from

Other

Android version

14

Device model

Pixel 5

First occurred

No response

Steps to reproduce

Download newest release atm (1.7.7) from GitHub
Install App
Get the info that you have to log in via patreon
"Log in with Google" button is greyed out/disabled

Example post, link, markdown...

I figure the log-in screen for patreon is only a redirection thing used during the auth process, so not technically handled by the infinity app. However the internal browser used to display the auth screen seems to be the issue.

The google login option being disabled when trying to login on patreon has been an issue for quite some time. Usually that happened because some necessary cookies were blocked by the browser.

Expected behaviour

To be able to login via google

Current behaviour

Option is disabled

Logs

No response

Docile-Alligator commented 4 months ago

It's because the login page is shown inside a webview.

IzzySoft commented 4 months ago

@Docile-Alligator I've just been informed of the Patreon requirement, so I marked it in NonFreeDep. Is it true the app now also requires a paid subscription? That would make another anti-feature necessary (NonFreeAdd or NonFreeDep, or both – as the app can no longer be used "freely"). Guess that was the reason why Infinity was removed from F-Droid? Looks like I need to consider the same for IzzyOnDroid: an app that requires payment to access a non-free network is quite border-line, even if the source is under a free license.

IzzySoft commented 4 months ago

PS: there is no fitting anti-feature for this. And the app description is misleading here:

It is completely free and ad-less

This contradicts the requirement of a paid subscription. What way out of this dilemma do you see, other than removing the app from IzzyOnDroid?

Docile-Alligator commented 3 months ago

@IzzySoft The app allows anonymous browsing for free. A subscription is only required when users login. I think I should change it to partially free?

IzzySoft commented 3 months ago

Yes, I agree. But then better mention that in that context. The current phrasing gives the impression it is… well, "completely free" :wink: Which is why I was reached out to.

It is completely free and ad-less; you can browse Reddit without interruptions or distractions (a paid subscription is only required when you want to login)

or something alike, maybe?

Docile-Alligator commented 3 months ago

@IzzySoft It has been changed to "partially free" with updated description.

IzzySoft commented 3 months ago

That's putting your light under the bushel, though – unless there are other limitations when not subscribed. "partially free" could be seen as "not fully libre", which would not be true. But you can probably tell better than I what would be the best phrasing there, I can just "suggest by hearsay"…

PS: I had suggested to include the subscription need to make that transparent, so nobody can complain.

genericusername87 commented 3 months ago

I think there is a misunderstanding here. @IzzySoft is redistributing the Patreon version instead of the Play version. But the paywall-less anonymous browsing mode only got implemented in the Play version, not the Patreon build.

@IzzySoft: The subscription model got necessary due to Reddit started charging Dev's for API usage on a per-request basis about a year ago. One can still compile the app yourself with your own API-key since <100 requests/min is free of charge afaik.

IzzySoft commented 3 months ago

the Patreon version instead of the Play version.

That's correct. I cannot find the related issue, but that was what we agreed on.

But the paywall-less anonymous browsing mode only got implemented in the Play version, not the Patreon build.

Oof. @Docile-Alligator while I understand the background, and this is of course no show-stopper for the listing at IoD, it needs to be made clear so folks know before they install. I see two paths here:

implement paywall-less anonymous browsing mode for the Patreon (and F-Droid) variants as well
update the description accordingly (should you use Fastlane for all variants, IoD supports any starting point for Fastlane structures so we could use a different tree if needed)

One can still compile the app yourself with your own API-key since <100 requests/min is free of charge afaik.

That's why it's no show-stopper for either F-Droid or IoD. But while F-Droid builds itself and thus could do what you're suggesting (I didn't check if it's set up there as reproducible build, which would rule out this option – or if they do patch it this way), IoD always takes the APKs from "upstream", i.e. those built & signed by the corresponding developers, and thus does not have this option.

genericusername87 commented 3 months ago

That's correct. I cannot find the related issue, but that was what we agreed on.

That was in the discussion section #1617

That's why it's no show-stopper for either F-Droid or IoD. But while F-Droid builds itself and thus could do what you're suggesting

I am sorry, that I was unclear here. I didn't mean to suggest this neither to you or to F-Droid but rather as something an interested and capable end user could do themselves since a single person is unlikely to exceed 100 requests/minute.

You or F-Droid distributing a build with your / their own Reddit API key to many users would of course result in exceeding the free rate limit and getting charged by Reddit. The same problem @Docile-Alligator is facing. (Apart from the fact that you would have to create your own key in the first place, which could be considered as actively promoting a non-free service)

IoD always takes the APKs from "upstream", i.e. those built & signed by the corresponding developers

And I really favor your approach above F-Droid's and am very thankful for your work! Because it allows timely updates and doesn't add another party to the chain of trust while giving the safeguards of an app store.

Sorry for getting offtopic. All I originally intended was to point out that the updated description doesn't match the offered Patreon version ^^

IzzySoft commented 3 months ago

You or F-Droid distributing a build with your / their own Reddit API key

Neither-or do that. F-Droid just builds from the source (yes, with some patching from time to time) but does not provide any "own" API keys. IoD, taking the "upstream APK", does not even have that option.

All I originally intended was to point out that the updated description doesn't match the offered Patreon version

That was what I understood, yes – thanks! I was just not sure if others would understand it the same way, hence the clarification :wink:

TL;DR: ball is with @Docile-Alligator once more then…

Docile-Alligator commented 3 months ago

@IzzySoft @genericusername87 Ah sorry for this. I totally forgot to implement a free anonymous mode for the Patreon version. This will be added very soon in the upcoming v7.2.7 update. The app description will also be changed.

IzzySoft commented 3 months ago

Thanks a lot, @Docile-Alligator!

Docile-Alligator commented 3 months ago

@IzzySoft v7.2.7 is now available.

IzzySoft commented 3 weeks ago

Oof, looks like I missed the notification. So I can close the issue on my end. Maybe you want to pick a badge to link to Infinity at IzzyOnDroid, @Docile-Alligator? Oh, and should the anti-feature description there need an update, please let me know.

Docile-Alligator commented 3 weeks ago

@IzzySoft Thank you! An updated badge is already in the README file! I will let you know if I need to update the anti-feature description.

IzzySoft commented 3 weeks ago

Thanks a lot!

Docile-Alligator / Infinity-For-Reddit