Docile-Alligator / Infinity-For-Reddit

A Reddit client for Android
https://play.google.com/store/apps/details?id=ml.docilealligator.infinityforreddit
GNU Affero General Public License v3.0
4.17k stars 404 forks source link

Proprietary components added with v0.4.0 #1649

Closed IzzySoft closed 3 months ago

IzzySoft commented 4 months ago

Checklist

App version

0.4.0

Where did you get the app from

Other

Android version

n/a

Device model

n/a

First occurred

with this version

Steps to reproduce

The library scanner reports:

Offending libs:
---------------
* Firebase Data Transport (/com/google/android/datatransport): NonFreeNet
* Google Mobile Services (/com/google/android/gms): NonFreeComp
* Firebase (/com/google/firebase): NonFreeNet,NonFreeComp
* Firebase Installations (/com/google/firebase/installations): NonFreeNet

4 offenders.

Not sure if those were added intentionally, or whether some dependency dragged them in – but they are proprietary and should not be there. Can you please take a look? Thanks in advance!

Docile-Alligator commented 3 months ago

There is no v0.4.0 version I think?

IzzySoft commented 3 months ago

Wait… what's going on there then? I usually have a complete block to post in such cases – but if there's no "simple issue" have to split up things, so parts of the block are missing. 2 weeks ago, now if I still remember… Let me check the logs here…

Oof. That day has just the usesCleartextTraffic for this app. Looks like the logs got messed up when cron sent them. Taking a closer look at what other apps were processed around the time, I find another one that seems to match the above, as the updater yielded the need to add the related anti-features. And yupp, that one matches with v0.4.0…

Apologies then, looks like I barked at the wrong tree :see_no_evil: