search

Docile-Alligator / Infinity-For-Reddit

A Reddit client for Android
https://play.google.com/store/apps/details?id=ml.docilealligator.infinityforreddit
GNU Affero General Public License v3.0
4.16k stars 405 forks source link

[5.0.0 beta1]Material You themes don't work properly #420

Open bczsalba opened 3 years ago

bczsalba commented 3 years ago

Enabling the Infinity Material You feature seems to always generate a bluish-grey theme, even when the system colors are very different.

Docile-Alligator commented 3 years ago

Hi could you try rebooting your device and see if your system color will be changed? Also, could you provide your wallpaper?

bczsalba commented 3 years ago

Okay, so rebooting after the color changed and re-enabling the option worked once, however I feel like the colors are a bit over saturated.

I'm using this built-in wallpaper at the moment, and these colors from it. Meanwhile, other apps like settings and Gboard use much more muted colors, where the system accent is only applied as a slight modifier.

I'm not sure how it all works under the hood, but I think these more muted colors would work better. Also, I'm not sure how it done, but all system apps with MU support refresh their themes live as it changes.

Thanks for working on this feature!

P.S.: I'm using a Pixel 5 on Android 12 Beta 3 if it makes any difference.

bczsalba commented 3 years ago

On further inspection, it does? seem to update when the system theme is updated, but not when I wanted it to do so.

bczsalba commented 3 years ago

Any update? I've been trying to create a theme generator using a combination of Tasker, Termux and Python, but it would be better if it was better in the app.

I also tried to contribute to the code, but then swiftly realized I have no clue about android development and couldn't even get the app the build. If that's better, after a quick explanation of how that all works I could change the code according to your guidelines to implement what I think the MY support should be like.

bczsalba commented 3 years ago

Bump again, I already have a Tasker profile & python script to generate themes from the MY colors, but the theme import fails (#432) with no clear indication as to why.

Docile-Alligator commented 3 years ago

The app does not use Android 12's system color and instead, it extracts some colors from the wallpaper and then applies some modifications to generate a theme.

LuminarySage commented 2 years ago

You should switch to using material you colors if the app is running on android 12. The system generates a much better pallette

LuminarySage commented 2 years ago

Like look at this. It's literally just a gray background somehow... I even restarted the app and stuff

Screenshot_20211101-195121 Screenshot_20211101-195731 Screenshot_20211101-195308 Screenshot_20211101-195200

bczsalba commented 2 years ago

@Wladefant was this issue ever resolved? Haven't seen any updates that suggest so.

Wladefant commented 2 years ago

@Wladefant was this issue ever resolved? Haven't seen any updates that suggest so.

It works for me, does it work for you?

bczsalba commented 2 years ago

It looks better than it used to, but IMO it's still not as good as alternatives like Sync. The header and FAB colors change to the primary and accent colors, but everything else (like comment indicators and background panes) remains unthemed.

I guess the issue (in this form) is redundant then!

Wladefant commented 2 years ago

Reopened it

LuminarySage commented 2 years ago

@Wladefant was this issue ever resolved? Haven't seen any updates that suggest so.

It works for me, does it work for you?

In v5.2.1 nothing changed