Docile-Alligator / Infinity-For-Reddit

A Reddit client for Android
https://play.google.com/store/apps/details?id=ml.docilealligator.infinityforreddit
GNU Affero General Public License v3.0
4.25k stars 409 forks source link

120hz support when scrolling #544

Open gochev opened 2 years ago

gochev commented 2 years ago

Currently testing on oneplus and other devices the scrolling seems a lot slower than any other app that supports 120 Hz scrolling.

This is opened as a response to @Docile-Alligator of a google play review I wrote.

https://play.google.com/store/apps/details?id=ml.docilealligator.infinityforreddit&reviewId=gp:AOqpTOEa6IiLuxlLYhBRa5AKWaUMdUPIHzEd2ir4-L0dRpZcovP3fxS3BWOPObLZqsq0Qu-_RbFOuYAv8w7Zbw

I cannot answer there so created the issue here. OnePlus doesn't have the list to include/exclude a specific app.

Tested on OnePlus 8T which have a 120Hz non stop without dynamic or anything like that scaling.

Maybe it is related to an old bug https://github.com/Docile-Alligator/Infinity-For-Reddit/issues/404but to me it seems like it is not since it is not related to video

P.S. some other apps that have 120hz support just have a lot smoother scrolling and I think this is the ONLY downside of Infinity (for example comparing it with Joey for Reddit).

Metalfan666 commented 2 years ago

I tested this after updating my S21 Ultra to OneUI 4 and my refresh rate stayed at 120hz the whole time and didnt dip below 120hz once.

gochev commented 2 years ago

Super strange maybe it is something related to OnePlus then :( the scrolling is super slow and laggy compared to apps like Instagram or jade for reddit if you scroll slow all the time you can't even read the posts without stoping

gochev commented 2 years ago

I was using Nord theme and was thinking it is theme dependant no it is not even with default I have not enabled material you

Metalfan666 commented 2 years ago

Im using Maximum Performance mode on my S21 Ultra with 16GB of ram, maybe that has something to do with it. The better phone you have the smoother it feels, or maybe its just a placebo effect. Samsung has very good 120hz optimization. I remember having scrolling issues on my old One Plus 6 Pro.

You can try to clear Infinity cache, or clear data and reinstall to see if that helps.

Metalfan666 commented 2 years ago

Possibly related: #436

Wladefant commented 2 years ago

@gochev Is this still an issue?

BitGrub commented 1 year ago

This is still an issue. On my Nothing Phone (1), the app sometimes launches in 60fps mode instead of the full 120. This is usually fixed if I close Infinity and reopen it.

It feels like a 50/50 success rate. Though the first open is usually the problematic one. I don't think it's an exclusion list issue, since it sometimes works.

I asked about this in various Android-focused forums and everyone considers this to point to an app-configuration issue, rather than device

Wladefant commented 1 year ago

Have seem multiple reports, will mark it as confirmed

Swastick-Paliwal commented 1 year ago

Using a Nothing Phone (1) and found this issue persists when videos are set to autoplay in the feed. The issue also persists if I force maximum refresh rate in the developer settings. So as a temporary solution you can turn autoplay videos to off in the settings for the app. Hope this helps!

BitGrub commented 1 year ago

Using a Nothing Phone (1) and found this issue persists when videos are set to autoplay in the feed. The issue also persists if I force maximum refresh rate in the developer settings. So as a temporary solution you can turn autoplay videos to off in the settings for the app. Hope this helps!

Didn't help. no change

adarsh1001 commented 1 year ago

Using a Nothing Phone (1) and found this issue persists when videos are set to autoplay in the feed. The issue also persists if I force maximum refresh rate in the developer settings. So as a temporary solution you can turn autoplay videos to off in the settings for the app. Hope this helps!

Can confirm that this somewhat fixes the issue on Nothing Phone (2) as well. Somewhat because the refresh rate now goes up to 90Hz for Infinity rather than just 60Hz with the autoplay turned off. Would like to see the whole 120Hz though.

ziomek64 commented 4 days ago

For me it's 60hz on OnePlus 12, no matter the settings I tried.