search

DockYard-Academy / curriculum

MIT License
945 stars 245 forks source link

Update images to use the new files directory after livebook 0.11.0 #1058

Closed scarolac closed 4 months ago

scarolac commented 4 months ago

Describe the issue With livebook 0.11.0+, the images folder no longer loads images. There is a provided script they had on the release notes for 0.11.0 which links to this gist https://gist.githubusercontent.com/jonatanklosko/20e28aa772a888a25a829337a4b805e1/raw/a0da10fe5b45b09197529a76a08c92b9d80d8047/convert_notebook_images.exs

Reproduction Steps (If Applicable) Steps to reproduce the behavior:

  1. Go to any livemd file that links to an image in images/*.png/jpg
  2. Livebook warning will show about this issue, and images from directory will not load

Expected behavior The images should be in the files directory and load when you open the livemd file

scarolac commented 4 months ago

I was able to run this locally on the release version in the reading folder and it seems to work but may need more testing for an official update

BrooklinJazz commented 4 months ago

a PR would be very welcome! My plate has been very full on other projects and curriculum maintenance is on the backburner right now so I likely won't have time to make a PR myself for awhile, but I would happily test and approve a fixed version.