DockYard / ember-admin

Admin backend for ember-cli projects
MIT License
241 stars 37 forks source link

Get Pretender from ember-cli-pretender. #17

Closed rwjblue closed 10 years ago

bcardarella commented 10 years ago

I thought these wrappers were bad?

rwjblue commented 10 years ago

SOOOOO bad, but they feel SOOOOO good. :stuck_out_tongue:

rwjblue commented 10 years ago

Also, totally up to you on this one, if you don't want to pull in ember-cli-pretender (understandable), then I'll do another PR to fixup/cleanup the way it is done in repo.

Just feels bad to have to do this for each repo (but wrapper packages feel bad too, I know).

bcardarella commented 10 years ago

@rwjblue I've been thinking about this, if the addon wrapper actually just had pretender & other deps in its bower.json file then why can't we run bower install for the addon after node installs? This would cleanly add those deps to bower_components and the wrapper's role could simply be to merge with ember-cli apps

bcardarella commented 10 years ago

The addon should pull whats in its own bower_components into the vendor tree

rwjblue commented 10 years ago

Yes, I worked a bit on this for ember-cli-qunit.

The only caveat is that it uses it's own packages bower_components directory (so it is not in the make consuming application dir or bower.json).

rwjblue commented 10 years ago

I can tweak ember-cli-pretender to do this in the morning.

rwjblue commented 10 years ago

Yeah, I think we are on the same page. I like the way we ended up on ember-cli-qunit (except that we have to depend on bower in the addon, but that isn't a HUGE deal).

rwjblue commented 10 years ago

Updated ember-cli-pretender to remove all vendored code. Now it simply calls bower install in a postinstall hook as discussed.

This PR has been updated to reflect the correct version.

rwjblue commented 10 years ago

@bcardarella - ping

bcardarella commented 10 years ago

yeah I saw it, I want to wrap up the relationships stuff before I pull in. Maybe tonight (if I'm lucky)

bcardarella commented 10 years ago

@rwjblue requires rebase